Clean CI run of gl hovers #3661
Merged
+78
−57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etpinard
reviewed
Mar 22, 2019
| @@ -374,56 +364,33 @@ describe('Test isosurface', function() { | |||
| ].join('\n') | |||
| }); | |||
| }) | |||
| .then(delay(20)) | |||
| .then(_hover3) | |||
| .then(function() { | |||
There was a problem hiding this comment.
It does not do anything positive other than causing errors. For the 3rd and 4th point locations we get different positions when using CI.
etpinard
reviewed
Mar 22, 2019
|
💃 |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A follow up of PR #3585 now to help run the
gl+hovertests on the CI much more smoothly! Recently we had to re-runjasmine2container few times after it failed several times which was not optimal.@plotly/plotly_js